-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cicero-server not working offline: options are not passed to "Template.fromDirectory()" in "initTemplateInstance()" #734
Comments
Thanks for the report. I agree that allowing Cicero server to be used offline would be useful. It sounds like adding a new environment variable to specify offline usage of the server would be a good idea? |
Thanks for the report @mgiofinc 🙌 This support is now added for |
Thanks for the update @mehmettokgoz. |
@mgiofinc Yes, that's right. I didn't refactor |
Hello and happy new year! @mehmettokgoz I was wondering if it is there any update about the refactoring of Thanks in advance. |
Hi! |
Bug Report 🐛
When
Template.fromDirectory()
is called withininitTemplateInstance()
(inpackages/cicero-server/app.js
), the options are not passed.This in particular prevents to use
cicero-server
offline.Expected Behavior
When "offline" option is set
true
in the request body,cicero-server
does not try to update external models.Current Behavior
When "offline" option is set
true
in the request body,cicero-server
tries anyway to update external models.Steps to Reproduce
cicero-server
as explained in theReadme.md
Draft request
call (it will download external models)Possible Implementation
Change
initTemplateInstance()
with something like:The text was updated successfully, but these errors were encountered: