Reformat code using clang-format and add CI/CD checks #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @abobija. You assigned this PR to me. Do you expect me to do something? |
|
No. I'll review it on my side as soon as I find some free time and I'll merge it if everything is OK. |
abobija
reviewed
Jun 9, 2024
Comment on lines
+4
to
+5
| pull_request: | ||
| push: |
There was a problem hiding this comment.
Please use pull_request_target instead of pull_request, it's safer. And remove push trigger (no need for it, because running workflow on pr is enough, what do you think?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal with this contribution is to simplify the collaboration with contributors. So I added a
.clang-formatfile with settings compatible with the IDF Style Guide. I also added a pre-commit hook to enforce the formatting rules.Then I added a pre-commit hook to check the code with
cppcheck. The tool discovered a couple of issues, so I fixed them.Finally, I configured the Github actions to check the formatting and to run
cppcheckon every commit. I also added a simple example and I use Github actions to compile the example with several architectures (currently esp32 end esp32-s3) and several IDF versions (currently v4.4.7, v5.1.4, and v5.2.1)Note : This pull request addresses the issue #38.