Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js sourcemaps are not generated #72

Open
arnaumanyosa opened this issue Jul 12, 2021 · 15 comments
Open

js sourcemaps are not generated #72

arnaumanyosa opened this issue Jul 12, 2021 · 15 comments
Labels
effort: med up to a week Hacktoberfest Issue that doesn't require previous experience with this project. impact: med minor perf improvements, fix broad userbase issues status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in this project

Comments

@arnaumanyosa
Copy link
Contributor

I'm aware of the previous issue

not sure how the fix worked for you, when basically you are telling webpack not to generate them.

@abhijithvijayan
Copy link
Owner

abhijithvijayan commented Jul 13, 2021

Using

new webpack.SourceMapDevToolPlugin({filename: false}),

plugin.

Do compare your webpack config against the current version in the respective branch and make the necessary changes.

@abhijithvijayan abhijithvijayan added status: awaiting author response Additional information has been requested from the author type: question or discussion Issue discussing or asking a question stale? Issue that may be closed soon due to the original author not responding any more. labels Jul 13, 2021
@abhijithvijayan
Copy link
Owner

abhijithvijayan commented Jul 17, 2021

broken somewhere along the way, checking this now.

there is a known issue in firefox

another reference: webpack/webpack#2145 (comment)

@abhijithvijayan
Copy link
Owner

resolved?

@arnaumanyosa
Copy link
Contributor Author

Not resolved

@came
Copy link

came commented Feb 3, 2022

I don't get any source maps neither using new webpack.SourceMapDevToolPlugin({filename: false})

@lsmith77
Copy link

same issue here.

I enabled sourceMap: true in tsconfig.json and devtool: 'source-map' in webpack.config.js

it is generating .map files, however these only contain a single file, f.e.:

{"version":3,"sources":[],"names":[],"mappings":"","file":"js/contentScript.bundle.js","sourceRoot":""}

so I suspect the issue is that it is generating the source map not from the source typescript files but from the generated javascript files.

the other issue is that enabling source-map in webpack is disabling minification via terser

@abhijithvijayan
Copy link
Owner

this is a critical issue, will pick this up soon and get it fixed.

@abhijithvijayan abhijithvijayan added impact: med minor perf improvements, fix broad userbase issues effort: med up to a week type: bug An issue or pull request relating to a bug in this project status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. and removed stale? Issue that may be closed soon due to the original author not responding any more. status: awaiting author response Additional information has been requested from the author type: question or discussion Issue discussing or asking a question labels Sep 26, 2022
@abhijithvijayan abhijithvijayan pinned this issue Sep 26, 2022
@abhijithvijayan
Copy link
Owner

abhijithvijayan commented Sep 26, 2022

will migrate to webpack 5 and see if this issue is persisting there. Webpack 5 has been out for sometime and is running without much issues these days.

there is a possibility that some of the plugins might not work in webpack 5, will be migrating that as well. also i would be upgrading to node 16.

The plugin / loader I created for this project also needs some migration for the webpack 5, i will be doing that as well.
ref: abhijithvijayan/wext-manifest-webpack-plugin#2

updates:

@abhijithvijayan
Copy link
Owner

abhijithvijayan commented Sep 26, 2022

support for webpack 5 is added for wext-manifest-loader in 3.0.0

had run into issues with the plugin while migrating, hopefully i can pick it up today and wrap it up

@abhijithvijayan abhijithvijayan added the Hacktoberfest Issue that doesn't require previous experience with this project. label Oct 3, 2022
@lsmith77
Copy link

let me know if there is something to test or if you have a branch I can help on. I have to admit this isn't my main area of expertise but maybe I can still help work through some issues.

@abhijithvijayan
Copy link
Owner

let me know if there is something to test or if you have a branch I can help on. I have to admit this isn't my main area of expertise but maybe I can still help work through some issues.

Thanks for the offer. I haven't forgotten about this issue. I have worked on the migration of the webpack plugin i wrote for this project but then there was complication as webpack 5 introduced some new apis and deprecated the api i was using there.

I will try n pick this up soon as well. Been caught up with work hence I couldnt get this done sooner.

Thanks for the patience. Will revert back with updates.

@abhijithvijayan
Copy link
Owner

Have migrated the webpack plugin as well. Will be testing it properly before going for a release. Will keep updating here.

@lsmith77
Copy link

any update? can we help with testing?

@lsmith77
Copy link

lsmith77 commented Jan 4, 2023

hello. happy new year!

I wonder if you are still motivated to look into this topic? thank you.

@lsmith77
Copy link

lsmith77 commented Jul 8, 2023

Alright, not sure if solving the issue also required some other dependency updates but it is now working for us by simply removing SourceMapDevToolPlugin and setting devtool to inline-source-map or source-map.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: med up to a week Hacktoberfest Issue that doesn't require previous experience with this project. impact: med minor perf improvements, fix broad userbase issues status: confirmed Issue with steps to reproduce the bug that’s been verified by at least one reviewer. type: bug An issue or pull request relating to a bug in this project
Projects
None yet
Development

No branches or pull requests

4 participants