Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mkDerivation finalAttrs call pattern? #107

Open
abathur opened this issue Sep 16, 2023 · 1 comment
Open

support mkDerivation finalAttrs call pattern? #107

abathur opened this issue Sep 16, 2023 · 1 comment

Comments

@abathur
Copy link
Owner

abathur commented Sep 16, 2023

I won't pretend to have the firmest grasp of this, but nixpkgs reviewers are leaning heavily on PR authors to use the mkDerivation (finalAttrs: ...) pattern first added in:

After skimming related PRs, my best guess is that I'll want to wait to tackle this until the following PR implementing lib.extendMkDerivation lands:

Since resholve's mkDerivation will need work to support this and it doesn't look immediately tractable, there'll probably be an increasing number of people getting asked to implement this (as in NixOS/nixpkgs#224881 (comment)) only to run into a dead end for now.

@D3vil0p3r
Copy link

Any news about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants