Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is this React 16 ready? #139

Open
joetidee opened this issue Aug 20, 2019 · 2 comments
Open

Is this React 16 ready? #139

joetidee opened this issue Aug 20, 2019 · 2 comments

Comments

@joetidee
Copy link

Noticed that in devDependencies that this is using React 15.3.1, so is it being tested with React 16 at all?
@jpsear
Copy link

jpsear commented Sep 12, 2019

We're using this with React 16 without issue.

However, there is now a warning being issued, due to the use of the soon to be deprecated componentWillReceiveProps (https://reactjs.org/blog/2018/03/27/update-on-async-rendering.html)

It looks like there is a PR to fix it here: #140, but it's not been merged...

@JackHowa
Copy link

JackHowa commented Oct 10, 2019 •
edited

Looks like it's been merged and published. Working for me locally with 4.1.1 without any deprecation warnings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpsear @JackHowa @joetidee