Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions/python installs too many requirements #542

Open
mdbenito opened this issue Mar 25, 2024 · 3 comments
Open

actions/python installs too many requirements #542

mdbenito opened this issue Mar 25, 2024 · 3 comments
Labels
CI GH actions for testing and packaging cleanup when code is ugly or unreadable and needs restyling

Comments

@mdbenito
Copy link
Collaborator

mdbenito commented Mar 25, 2024

In the "setup python" github action, both dev and docs requirements are always installed. But this action is used e.g. in the build docs stage in the main workflow, where dev requirements shouldn't be necessary.

@mdbenito mdbenito added CI GH actions for testing and packaging cleanup when code is ugly or unreadable and needs restyling labels Mar 25, 2024
@AnesBenmerzoug
Copy link
Collaborator

That takes about 40s though. How much time would we shave off that?

@mdbenito
Copy link
Collaborator Author

Half? But that accrues over hundreds of runs and I don't see the point of wasting build minutes without reason.

@AnesBenmerzoug
Copy link
Collaborator

I did a bit of benchmarking and it turns out that installing the documentation dependencies takes as much time as if not more than the main dependencies (not including any optional ones like PyTorch for example). You're right, we should optimize that.

Docs dependencies Main dependencies
Without Cache real 1m0,479s
user 0m48,623s
sys 0m4,046s
real 0m52,664s
user 0m41,056s
sys 0m2,824s
With Cache real 0m41,236s
user 0m35,469s
sys 0m2,846s
real 0m46,728s
user 0m42,487s
sys 0m3,201s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI GH actions for testing and packaging cleanup when code is ugly or unreadable and needs restyling
Projects
None yet
Development

No branches or pull requests

2 participants