Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include shape in array types #541

Open
mdbenito opened this issue Mar 24, 2024 · 1 comment
Open

Include shape in array types #541

mdbenito opened this issue Mar 24, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mdbenito
Copy link
Collaborator

Using nptyping and beartype we can pin down the dimensions that we accept. For instance, the constructor of ValuationResult can only accept 1D arrays but we don't enforce that.

Alternatively, jaxtyping supports jax, torch and numpy in one go. But python 3.9 is required so we'd have to wait until EOL for 3.8 at the very least.

Are there any other libraries?

@mdbenito mdbenito added enhancement New feature or request good first issue Good for newcomers labels Mar 24, 2024
@mdbenito
Copy link
Collaborator Author

mdbenito commented May 7, 2024

@janosg @schroedk this could be a valid reason to expedite deprecation of 3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant