-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible/impracticable to undo automated filter placement in Design LTN tool #1116
Comments
This was a problem introduced by #1085. It's possible we need to rethink the |
Ah, I slightly misread the issue -- a related problem is the use of the freehand filter tool. The user can introduce a bunch of new filters with one logical operation, but then has to undo filters individually (in an arbitrary order). That's another case where we'd want to logically batch edits. |
How to reproduce
Expected behaviour
The user should be able to undo the filter placement with a single undo.
Actual behaviour
The user may need to select undo > 100 times in order to return to the state before automatically placing the filter.
(It seems that an edit is made and undone for each candidate filter (see
abstreet/apps/ltn/src/logic/auto_filters.rs
Line 105 in 7000260
The text was updated successfully, but these errors were encountered: