Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concat order issue? #1

Open
shifengren opened this issue Apr 21, 2019 · 2 comments
Open

Concat order issue? #1

shifengren opened this issue Apr 21, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@shifengren
Copy link

shifengren commented Apr 21, 2019

Nice work!
The version of implementation can reach 22+ BLUE score. However, my implementation have only 0.16+ BLUE score on test dataset. Comparing with your work, I found changing the concatenation torch.cat((Y_t, o_pre), dim=1) to torch.cat((o_pre, Y_t), dim=1) can only reach 0.16+ BLUE score.

B.W.T. chaging the concatenating order between dec_hidden and a_t in step function also resulting in bad BLUE score in test dataset.

Would you like share your ideas why concatenating Y_t and o_pre in such way?

Thank you!

@ZacBi ZacBi pinned this issue Jun 3, 2019
@ZacBi
Copy link
Owner

ZacBi commented Jun 3, 2019

I'm sorry for the response after so long time. It's a very interesting question and exploration.

My intuition is that the way matrics concats is same, the difference is just the order between Y_t and o_pre. In other words, you can consider the order of weights of Y_t and o_pre exchanges(of course they still exist in the same weight matrix). I didn't think so much when I finish the network because I just follow the handout. so your case confused me and I am trying to work it out now.

I'll reply to you as soon as possible.

@ZacBi ZacBi unpinned this issue Jun 3, 2019
@ZacBi ZacBi pinned this issue Jun 3, 2019
@ZacBi ZacBi added the good first issue Good for newcomers label Aug 9, 2019
@ZacBi ZacBi unpinned this issue Nov 9, 2019
@BlankCheng
Copy link

It's tested in (Y_t, o_prev) order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants