Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing slash in location needed #7

Open
arthurzenika opened this issue Jan 10, 2018 · 2 comments
Open

Trailing slash in location needed #7

arthurzenika opened this issue Jan 10, 2018 · 2 comments

Comments

@arthurzenika
Copy link

We have a web application that when behind nginx, needs to have a trailing slash, so the default config :

location /demo {
  proxy_path  http://internal.example.org:8080/;
[snip]

Needs to be modified to

location /demo/ {
  proxy_path  http://internal.example.org:8080/;
[snip]

The "path" key in settings does include that trailing slash

settings: 
  domain: example.org
  id: redirect
  [snip]
  path: /demo/

What is the right way to do this ? In the template ? Somewhere in the configuration ?

@opi
Copy link
Contributor

opi commented Feb 4, 2019

I don't remember why, but the trailing slash is removed on purpose https://github.com/YunoHost-Apps/redirect_ynh/blob/master/scripts/install#L30 ;

But if your app need it, you should edit your nginx config file in /etc/nginx/conf.d/domain.conf (or domain.conf.d/youapp.conf)

@zamentur
Copy link
Contributor

In this pr the trailing slash will be managed like on all other apps in yunohost.
#37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants