Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block join reason to reaction #3190

Merged
merged 3 commits into from
May 30, 2024
Merged

Conversation

CringeArab
Copy link
Contributor

Closes #3131
Closes #1991
pic

maybegreat48
maybegreat48 previously approved these changes May 27, 2024
Copy link

github-actions bot commented May 27, 2024

Download the artifacts for this pull request:

@binded-zz
Copy link

this looks totally awsome
small request to add too this if at all possible
any way to add grouping in player database like show by group
so you put them in cheater block show only cheaters

i tired to do something about a year ago but this wasnt even a option then it was like blocked friends and modders but i couldnt make it work out i had colors and other stuff circles in circles and it was a no go

but maybe just a drop list under search but not only block reasons maybe add friends modders trusted and command use as well then just show online offline invite only for that group

@Yimura
Copy link
Member

Yimura commented May 28, 2024

@binded-zz, don't mistake this PR is only for this feature being added. Not a place to request other features on top of what has already been made.

@binded-zz
Copy link

sorry about the feature request on top of the PR

this looks so awesome

@Yimura Yimura merged commit fd939c4 into YimMenu:master May 30, 2024
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2024
@CringeArab CringeArab deleted the block-join-reason branch May 30, 2024 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants