Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: Block Vehicle Spam, Particle Spam & Smoke from a Player that mod #3058

Open
2 tasks done
AhmadToamah2010 opened this issue May 5, 2024 · 3 comments
Open
2 tasks done
Labels
request New feature or request

Comments

@AhmadToamah2010
Copy link

AhmadToamah2010 commented May 5, 2024

Describe the bug

Vehicle Spamming, Particle Spam & Smoke from a Mod Menu

Steps To Reproduce

  1. Go to Online 2. Wait someone has a Mod Menu 3. Get Vehicle Spammed, Particle Spam or Smoked 4. The Game will be ultra laggy or a black screen will appear

Expected Behavior

Block Vehicle Spam, Particle Spam & Smoke

Logs

Idk if the log helps

[18:53:25.2917161][INFO/main.cpp:156] Settings Loaded and logger initialized.
[18:53:25.2917467][INFO/main.cpp:158] Yim's Menu Initializing
[18:53:25.2917499][INFO/main.cpp:159] Git Info
Branch: master
Hash: d957658
Date: Fri May 3 18:53:59 2024
[18:53:25.2918273][INFO/main.cpp:93] Unable to read registry key DisplayVersion
[18:53:25.2918604][INFO/main.cpp:171] Windows 10 Pro Version (OS Build 17763.5458)
[18:53:25.2926389][DEBUG/thread_pool.cpp:22] Resizing thread pool from 0 to 4
[18:53:25.2929501][INFO/main.cpp:179] Thread pool initialized.
[18:53:25.2949644][INFO/pointers.hpp:94] GTA5 pointers cache is up to date, using it.
[18:53:25.2950091][INFO/pointers.cpp:1839] Loading pointers instance from cache
[18:53:25.2950177][INFO/pointers.cpp:1848] Pointers cache: Loading 218 fields from the cache
[18:53:25.2950324][DEBUG/module.cpp:55] Waiting for socialclub.dll...
[18:53:25.2951841][INFO/pointers.hpp:94] Social Club pointers cache is up to date, using it.
[18:53:25.2951880][INFO/pointers.cpp:1839] Loading pointers instance from cache
[18:53:25.2951895][INFO/pointers.cpp:1848] Pointers cache: Loading 5 fields from the cache
[18:53:25.2952153][INFO/main.cpp:182] Pointers initialized.
[18:53:25.2952199][INFO/main.cpp:189] Disabled anticheat gameskeleton.
[18:53:25.2953004][INFO/main.cpp:192] Byte Patch Manager initialized.
[18:53:25.2954724][INFO/main.cpp:195] Renderer initialized.
[18:53:25.3027366][INFO/main.cpp:199] Fiber pool initialized.
[18:53:25.3032350][INFO/main.cpp:202] HTTP Client initialized.
[18:53:25.5662481][DEBUG/thread_pool.cpp:96] Thread 3760 executing font_mgr.cpp:104
[18:53:25.5667747][INFO/main.cpp:205] Translation Service initialized.
[18:53:25.6103146][INFO/main.cpp:208] Hooking initialized.
[18:53:25.6166897][DEBUG/gta_data_service.cpp:160] Loading data from cache.
[18:53:25.6167058][INFO/gta_data_service.cpp:172] Loading 1051 peds from cache.
[18:53:25.6170861][INFO/gta_data_service.cpp:190] Loading 843 vehicles from cache.
[18:53:25.6173819][INFO/gta_data_service.cpp:207] Loading 119 weapons from cache.
[18:53:25.6173860][INFO/gta_data_service.cpp:208] Loading 380 weapon components from cache.
[18:53:25.6174012][DEBUG/gta_data_service.cpp:166] Loaded all data from cache.
[18:53:25.6183582][DEBUG/thread_pool.cpp:96] Thread 3760 executing player_database_service.cpp:285
[18:53:25.6184369][INFO/main.cpp:228] Registered service instances...
[18:53:25.6184494][INFO/main.cpp:231] Finished initialising services.
[18:53:25.6185375][INFO/main.cpp:252] Scripts registered.
[18:53:25.6301451][INFO/main.cpp:255] Hooking enabled.
[18:53:25.6319223][INFO/main.cpp:258] Dynamic native hooker initialized.
[18:53:25.6553547][INFO/log.cpp:17] sch.lua: sch-lua v3.23 For personal testing and learning only, commercial use is prohibited
[18:53:25.6595574][INFO/log.cpp:17] sch.lua: sch-lua已适配您的当前游戏版本.
[18:53:25.6616027][INFO/lua_module.cpp:330] Loaded sch.lua
[18:53:25.6616739][INFO/main.cpp:262] Lua manager initialized.
[18:53:26.5185362][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x45A3A8
[18:53:26.5185622][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x5CAA60
[18:53:26.5194279][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x318D08
[18:53:26.5255155][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x961FBC
[18:53:26.5257177][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x66F09C
[18:53:26.5257264][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x66F0C4
[18:53:26.5257392][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x66F0EC
[18:53:26.5257444][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x66F074
[18:53:26.5259842][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x335660
[18:53:26.5259931][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x335638
[18:53:26.5260006][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x4015B8
[18:53:26.5264279][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0x45B164
[18:53:27.2613298][INFO/backend.cpp:53] Starting script: Self
[18:53:27.2613699][INFO/backend.cpp:78] Starting script: Weapons
[18:53:27.2613827][INFO/backend.cpp:101] Starting script: Vehicles
[18:53:27.2613936][INFO/backend.cpp:117] Starting script: Miscellaneous
[18:53:27.2614231][INFO/backend.cpp:138] Starting script: Remote
[18:53:27.2614294][INFO/backend.cpp:153] Starting script: Ls customs
[18:53:27.2614335][INFO/backend.cpp:165] Starting script: Rainbow paint
[18:53:27.2614357][INFO/backend.cpp:177] Starting script: Disable Control Action
[18:53:27.2614398][INFO/backend.cpp:190] Starting script: World
[18:53:27.2706146][INFO/tunables_service.cpp:36] Loading tunables from cache
[18:53:54.6529940][WARN/prepare_metric_for_sending.cpp:93] BAD METRIC: MM; DATA: "mmList":"4B45524E454C33322E444C4C00|4B45524E454C424153452E646C6C00|61707068656C702E646C6C00|41634C61796572732E444C4C00|6D73766372742E646C6C00|5553455233322E646C6C00|47444933322E646C6C00|676469333266756C6C2E646C6C00|6D737663705F77696E2E646C6C00|7563727462
[18:53:54.6531911][WARN/prepare_metric_for_sending.cpp:93] BAD METRIC: MM; DATA: "mmList":"57494E485454502E646C6C00|4D535643503134302E646C6C00|564352554E54494D453134302E646C6C00|564352554E54494D453134305F312E646C6C00|636C62636174712E646C6C00|6478646961676E2E646C6C00|53455455504150492E646C6C00|7762656D70726F782E646C6C00|7762656D636F6D6
[18:54:00.1015138][DEBUG/script_function.cpp:35] Found pattern SFSA in script freemode
[18:54:04.6390569][WARN/prepare_metric_for_sending.cpp:93] BAD METRIC: UVC; DATA: "vc":false
[18:54:04.6390747][WARN/prepare_metric_for_sending.cpp:93] BAD METRIC: RDEV; DATA: "g":"SC 226299449"
[18:54:04.6392017][WARN/prepare_metric_for_sending.cpp:93] BAD METRIC: AWARD_XP; DATA: "amt":1787576850,"type":3136273443,"cat":654913086,"pt":758954778,"slot":0
[18:54:15.5276374][INFO/queue_dependency.cpp:63] Blocking AC Verifier 0xA66114
[18:56:54.6487751][WARN/prepare_metric_for_sending.cpp:93] BAD METRIC: UVC; DATA: "vc":false
[19:01:20.6480831][INFO/lua_module.cpp:330] Loaded Extras-data.lua
[19:01:22.0672586][INFO/lua_module.cpp:330] Loaded Extras-Addon.lua
[19:01:24.1521133][INFO/lua_module.cpp:330] Loaded json.lua

Screenshots / Video

Store

Epic Games

Language

English

YimMenu Language

English (US)

Additional context

Please fix it

Build

  • I've confirmed the issue exists on the latest version of YimMenu

Coload

  • I've tested this without co-loading anything.
@AhmadToamah2010 AhmadToamah2010 added the bug Something isn't working label May 5, 2024
@CringeArab
Copy link
Contributor

It’s strange that no one thought about this, maybe it’s worth adding protection against spam for objects? How is this implemented in stand, like auto-cleaning of identical peds, RPG shells, etc. if they exceed the value of 50. Although we have a function for cleaning objects and cars, we could simply add auto-cleaning when the pool is full.

@rkwapisz
Copy link
Contributor

rkwapisz commented May 5, 2024

How many vehicles do you think we'd need to protect against? You'd basically have to keep an ongoing collection of objects around you every tick which would probably be an overall bigger performance hit than an occasional spammer.

Also there is a significant potential for false positives.
Think about LSCM or the parking in front of the casino, where you can have lots of vehicles in one area, and you wouldn't want to start deleting legitimate objects automatically.

@gir489returns gir489returns changed the title [Bug]: Block Vehicle Spam [Request]: Block Vehicle Spam May 6, 2024
@gir489returns gir489returns added request New feature or request and removed bug Something isn't working labels May 6, 2024
@0xEmiil
Copy link

0xEmiil commented May 6, 2024

How many vehicles do you think we'd need to protect against? You'd basically have to keep an ongoing collection of objects around you every tick which would probably be an overall bigger performance hit than an occasional spammer.

Also there is a significant potential for false positives. Think about LSCM or the parking in front of the casino, where you can have lots of vehicles in one area, and you wouldn't want to start deleting legitimate objects automatically.

Whats your point ?

@AhmadToamah2010 AhmadToamah2010 changed the title [Request]: Block Vehicle Spam [Request]: Block Vehicle Spam & Particle Spam May 9, 2024
@AhmadToamah2010 AhmadToamah2010 changed the title [Request]: Block Vehicle Spam & Particle Spam [Request]: Block Vehicle Spam, Particle Spam & Smoke from a Player that mod May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants