-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide generic Interpolator #30
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, nice library and great animation. However, I think the interpolators at the moment is created based on some pre-calculated constants. For example, in
ActionBarInterpolator
:The constants used in
getInterpolation
(e.g., -28.4444f) are pre-calculated based on the values ofFIRST_BOUNCE_PART
andSECOND_BOUNCE_PART
. If either or both of these values are changed, the constant values need to be recalculated.This limit users of this library from changing the value of
FIRST_BOUNCE_PART
and/orSECOND_BOUNCE_PART
to whatever they want because if they change these values, they have to do their own math to work out formulas for the interpolators.So I think it would be nicer to provide generic formulas for interpolators with perhaps
FIRST_BOUNCE_PART
andSECOND_BOUNCE_PART
are variables to avoid users being worrying about the formulas themselves.What do you think?
The text was updated successfully, but these errors were encountered: