-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Innermost hasAwaitStarted catch block is a no-op and could be omitted #145
Comments
In that particular case you are right. If you want an example where this is relevant check out the test We definitely could improve codegen to detect this scenario and remove the unnecessary bookkeeping. |
Makes sense. I'm not too concerned. Do you want to leave this issue open to track skipping this try block for the innermost await? |
Yep, thanks |
How can
!hasAwaitStarted_a_1_1
in the catch block ever not evaluate tofalse
? It's not assigned anywhere else.stronginject/StrongInject.Tests.Unit/GeneratorTests.cs
Lines 7112 to 7125 in 2143d9f
The text was updated successfully, but these errors were encountered: