-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom arrow causes a warning in the console #402
Comments
Hi, Can you provide the '...restArrowProps'? I suspect that '...restArrowProps' has some prop that gets the boolean value, but expects the other type of value instead of boolean |
Actually reading the files i found that arrowProps which you populate are also have one extra prop 'rtl' which is boolean interface RightArrowProps {
customRightArrow?: React.ReactElement<any> | null;
getState: () => StateCallBack;
next: () => void;
disabled?: boolean;
rtl?: boolean;
} where it provides rtl you can also skip rtl by doing |
`const customleftarrow = ( <ArrowBackIcon sx={{ color: "white" }} /> ); const customrightarrow = ( <ArrowForwardIcon sx={{ color: "white" }} /> ); const ArrowFix = (arrowProps) => { const {carouselState, children,rtl, ...restArrowProps} = arrowProps; return ( <span {...restArrowProps}> {children} ); }; return ( <Carousel
|
Describe the bug
Custom arrow causes a warning in the console: **Warning: Received
false
for a non-boolean attributertl
. If you want to write it to the DOM, pass a string instead: rtl="false" or rtl={value.toString()}.If you used to conditionally omit it with rtl={condition && value}, pass rtl={condition ? value : undefined} instead.**
To Reproduce
Create a custom arrow
Expected behaivor
No warnings
Screenshots
(screenshots of the warning, the arrow functions and the carousel itself)
The text was updated successfully, but these errors were encountered: