Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDM/src/c_boost/expr/ast_common.hpp missing include of sstream #11

Open
tvrusso opened this issue Feb 15, 2024 · 1 comment · May be fixed by #12
Open

XDM/src/c_boost/expr/ast_common.hpp missing include of sstream #11

tvrusso opened this issue Feb 15, 2024 · 1 comment · May be fixed by #12

Comments

@tvrusso
Copy link
Member

tvrusso commented Feb 15, 2024

ast_common.hpp uses std::istringstream, but does not include <sstream>.

This caused an XDM build failure on my system for the first time in a long time. It used to build just fine this way, but something must have changed in a boost update that removed some upstream include of that header from boost headers. My last build used boost 1.83, but my system updated to boost 1.84 today and that caused xdm to have a missing dependent library. Trying to rebuild to fix that exposed the problem.

Inserting an include of this header into that file fixes the problem for me. Inserting it immediately after the include of <unordered_map> did the trick for me.

Tagging @Karlsefni2012, @gjtempl, and @TBird2001 directly to make sure they see this.

@tvrusso tvrusso linked a pull request Feb 15, 2024 that will close this issue
@tvrusso
Copy link
Member Author

tvrusso commented Feb 15, 2024

tagging @dc-snl just for grins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant