Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuantTensor always valid #844

Open
Giuseppe5 opened this issue Feb 13, 2024 · 0 comments
Open

QuantTensor always valid #844

Giuseppe5 opened this issue Feb 13, 2024 · 0 comments

Comments

@Giuseppe5
Copy link
Collaborator

At the moment, when we sum or concatenate two QuantTensors at training time, we do not assume anything about their scale factors, and we average them.

The drawback of this approach is that the resulting QuantTensor is not valid, i.e. cannot be converted to its integer representation.
A better approach would be to adjust scale factors and bitwidth to make sure that the resulting QuantTensor is always valid.

@nickfraser Your input would be appreciated here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant