Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Gaussian Linear Blur effect broken #822

Closed
YorVeX opened this issue Jun 11, 2022 · 7 comments
Closed

Gaussian Linear Blur effect broken #822

YorVeX opened this issue Jun 11, 2022 · 7 comments
Labels
bug Bugs such as crashing, freezing, broken functionality, etc. can't-fix Issues that can't or won't be fixed.

Comments

@YorVeX
Copy link

YorVeX commented Jun 11, 2022

Operating System

Windows 10 1903 and higher

OBS Studio Version?

27.1

StreamFX Version

0.11.1

OBS Studio Log

Really doesn't matter

OBS Studio Crash Log

No response

Current Behavior

Adding a Blur effect of "Gaussian Linear" type does nothing, original output stays unchanged.

Expected Behavior

Blur effect being applied.

Steps to Reproduce the Bug

Add "Blur" filter to e.g. an image source, set the type to "Guassian Linear", try various settings like "Subtype" or "Size", they all do nothing. "Gaussian" in comparison works fine.

Any additional Information we need to know?

I tried my previous version StreamFX 0.9.3.0 as a comparison and the filter works fine there. When I go back to 0.11.1 it stops working again.

As an additional test I copied the data\obs-plugins\StreamFX\effects\blur\gaussian-linear.effect over from the StreamFX 0.9.3 package. Interestingly this is working, but needs a higher "Size" settings to achieve the same blur level.

@YorVeX YorVeX added status:help-wanted bug Bugs such as crashing, freezing, broken functionality, etc. labels Jun 11, 2022
@Xaymar
Copy link
Owner

Xaymar commented Jun 11, 2022

"Linear" variants will become the default in the future, and have been phased out as a separate option. There is a WIP complete rework of the blur filter. Please use Dual Filtering instead of Gaussian or Box blur as well.

@YorVeX
Copy link
Author

YorVeX commented Jun 12, 2022

The current description indicates that Dual Filtering doesn't fit all use cases though:

Should be preferred if fine control over blur size is not required.

But I appreciate that hint, because actually all of my use cases so far could be covered by Dual Filtering even when controls are not as fine as for the other blur options - and if it's faster at the same time I prefer that of course.

@Xaymar
Copy link
Owner

Xaymar commented Jun 12, 2022

Dual Filtering can only be controlled in 2^N steps, where you control N. After a size of 16px (4 in Dual Filtering), there is practically no practical need for other blur steps. Though it is possible to emulate this, and a lot of software out there does it - downscale the source with linear first to a fraction of the size but no less than 50%, then upscale after blur with linear to original size. 1/100th of the cost of actual Gaussian Blur, for a 95% accurate Gaussian blur approximation.

@GT500org
Copy link

Personally I find all of the built-in blur options to be way too blurry even on their lowest setting, so I use the gaussian blur shader for more fine grained control. It allows me to add only enough blurring to prevent compression artifacting, without adding more than necessary.

@YorVeX
Copy link
Author

YorVeX commented Jun 13, 2022

Yeah, after working through my OBS config I had also found two cases where I apply the blur effect to a Text source to smoothen the overall look after several other effects had been applied to it before. And there if I just go up one small notch with the blur the text just looks plain stupid, so there is no way to use Dual Filtering on that. But Xaymar said "Linear variants will become the default" and I was using Box filter there so I just switched to Box linear and hopefully I am fine now also for future StreamFX updates?

@Xaymar
Copy link
Owner

Xaymar commented Jun 21, 2022

Since the option to select them will be removed entirely and just become the same as selecting "Box" or "Gaussian" (Dual Filtering will also be merged into "Gaussian"!) it won't make much of a difference. StreamFX will attempt to automatically migrate all older settings to the new system anyway, so you won't even notice the change.

@Xaymar Xaymar modified the milestone: 0.12 Jul 31, 2022
@Xaymar
Copy link
Owner

Xaymar commented Mar 14, 2023

Gaussian will be undergoing a rewrite for v0.12, see #1036. Closing as not planned.

@Xaymar Xaymar closed this as not planned Won't fix, can't repro, duplicate, stale Mar 14, 2023
@Xaymar Xaymar added the can't-fix Issues that can't or won't be fixed. label Mar 14, 2023
@Xaymar Xaymar added this to the Blur (Component, Filter) milestone Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Bugs such as crashing, freezing, broken functionality, etc. can't-fix Issues that can't or won't be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants