New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glynn method has an weird prefactor #376

Open

hsgyc opened this issue Jan 1, 2024 · 1 comment

hsgyc commented Jan 1, 2024

In Hafnian evaluation function, including _calc_hafnian and _calc_loop_hafnian, there is a weird factor multiplication.

if glynn and kept_edges[0] == 0:
            prefac *= 0.5

However, when glynn method is invoked, keps_deges has value in {-1, 1} and will never be zero. So this code block makes no sense.

The text was updated successfully, but these errors were encountered:

Collaborator

nquesada commented Jan 1, 2024

Could you make a PR removing that line, to see if the tests pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment