Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click range stability #79

Open
XVs32 opened this issue Jan 13, 2024 · 4 comments · Fixed by #83
Open

Click range stability #79

XVs32 opened this issue Jan 13, 2024 · 4 comments · Fixed by #83
Assignees
@XVs32
Labels
bug Something isn't working keeps track Needs long term attention

Comments

@XVs32
Copy link
Owner

XVs32 commented Jan 13, 2024 •
edited

What

  • Chrome drive click has low chance not clicking on the right spot
  • Find the reason why, and see if this affect direct control too

How

  • How to achieve the goal here

Result

Reference

  • url, pdf, ppt etc.
@XVs32 XVs32 added the bug Something isn't working label Jan 13, 2024
@XVs32 XVs32 self-assigned this Jan 13, 2024
@XVs32
Copy link
Owner Author

XVs32 commented Jan 14, 2024

First, I will have to see if direct control and chrome driver is getting the correct game window range

@XVs32
Copy link
Owner Author

XVs32 commented Jan 14, 2024 •
edited

I double checked the top left coor return from kcauto and it looks alright

Next I am going to check the pad range for factory button and bucket enable button

@XVs32
Copy link
Owner Author

XVs32 commented Jan 14, 2024

The coor of factory button is kinda off, it is tweaked in b98476c

The bucket enable button, however, uses kca_u.kca.click_existing() with a pad of 0,0,0,0, I will keep an eye to the log when it happens next time

@XVs32 XVs32 linked a pull request Jan 14, 2024 that will close this issue
factory button coor tweak #83
Merged
@XVs32 XVs32 closed this as completed in #83 Jan 14, 2024
@XVs32
Copy link
Owner Author

XVs32 commented Jan 14, 2024 •
edited

Since I want to see if not using bucket issue happens again, I will keep this issue open for now

@XVs32 XVs32 reopened this Jan 14, 2024
@XVs32 XVs32 added the keeps track Needs long term attention label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XVs32 XVs32

Labels
bug Something isn't working keeps track Needs long term attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

factory button coor tweak XVs32/kcauto_custom
1 participant
@XVs32