-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading output when using query with location and nrows #36
Comments
Hey @pvanheus, internally GISAIDR runs a loop to batch queries with > 50 rows requested. I'm not sure how to check the commit unless you installed from a specific commit with a command like:
I'm pretty careful with the version number so you could try to match that up with the commit it changed (e.g. search the commits for your version number). I haven't been using release tags because any old version of GISAIDR is essentially out of date i.e. if GISAID changes it breaks all previous versions. Hope that helps in someway! |
Hi there... so that message should be read as "Returning entries at positions X-Y in the list of Z total entries"? I got confused because I thought "hey, I've asked for 1000 entries, why is it telling me about the whole collection". I think the issue is that there's 2 levels involves: entries X-Y out of the ones you asked for, and then the total number of entries out there. I can't really think of better wording though. |
Ah I get your point! Will see what I can do to make it a bit clearer... I will have to refractor things at some point 😅 |
With the following query:
I get the following output:
I.e. it is doing the right thing but printing misleading output.
P.S. how can I check which commit my current GISAIDR install is from, in order to provide a "version number"?
The text was updated successfully, but these errors were encountered: