Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further robustness for putClientSettings #1904

Open
2 tasks
matthewblain opened this issue Dec 30, 2020 · 1 comment
Open
2 tasks

Further robustness for putClientSettings #1904

matthewblain opened this issue Dec 30, 2020 · 1 comment
Labels
needs:triage New issue that needs triage resolved:stale No recent activity on the issue or PR source:public Issues created by the public

Comments

@matthewblain
Copy link
Contributor

Summary

Increase robustness in corner cases possibly encountered by putClientSettings

Follow-on to issue #1524

Inconsistent results should be highly unlikley now, as the entire client configuration is passed to the server. In the typical UI flow there will be an update which should write the correct value.

Robustness improvments could include:

Add a transaction to the server so an error will be reported on 'collision.'
Have the client retry on error somehow. Perhaps by recording a timestamp for last client side update and last server side sync, and occasionally validating that the two match.
Have the client report errors, e.g. add an event to who_service like widget.analytics.logEvent(name: 'WhoServicePutClientSettings', parameters: {'result': response.statusCode});

Reproduction Steps

Somehow rapidly make client changes using a slow server.
Result: Possibly something other than the last setting will be the perised one.

Expected Behavior

Simultaneous requests will error out in some reasonable fashion.

System

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • App Version: [1.2.0+14]

Additional Context

Add any other context about the problem here.

Screenshots

Screenshots Add any relevant screenshots here

Checklist:

@matthewblain matthewblain added needs:triage New issue that needs triage source:public Issues created by the public labels Dec 30, 2020
@stale
Copy link

stale bot commented Jan 31, 2021

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the resolved:stale No recent activity on the issue or PR label Jan 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage New issue that needs triage resolved:stale No recent activity on the issue or PR source:public Issues created by the public
Projects
None yet
Development

No branches or pull requests

1 participant