Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using instance id api to properly sync notification topics #1865

Open
advayDev1 opened this issue Dec 21, 2020 · 5 comments
Open

Consider using instance id api to properly sync notification topics #1865

advayDev1 opened this issue Dec 21, 2020 · 5 comments
Labels
needs:triage New issue that needs triage resolved:stale No recent activity on the issue or PR source:public Issues created by the public

Comments

@advayDev1
Copy link
Contributor

Given that country changing is now allowed, the topic management code is fragile.

Instead of keeping track of which topics are subscribed to in the user db, instead go to the source of truth: https://developers.google.com/instance-id/reference/server#get_information_about_app_instances and add or remove topics based on that list.

@advayDev1 advayDev1 added needs:triage New issue that needs triage source:public Issues created by the public labels Dec 21, 2020
@brunobowden
Copy link
Collaborator

Agreed. This part of the system definitely needs an overhaul.

@matthewblain
Copy link
Contributor

@advayDev1
Copy link
Contributor Author

I will take a look monday

@advayDev1
Copy link
Contributor Author

Added comments for what i remember @matthewblain

@stale
Copy link

stale bot commented Jan 23, 2021

This item has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the resolved:stale No recent activity on the issue or PR label Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage New issue that needs triage resolved:stale No recent activity on the issue or PR source:public Issues created by the public
Projects
None yet
Development

No branches or pull requests

3 participants