Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Profile links to View Profile where applicable. #268

Open
StevenDufresne opened this issue Sep 13, 2022 · 6 comments · May be fixed by #600
Open

Update Profile links to View Profile where applicable. #268

StevenDufresne opened this issue Sep 13, 2022 · 6 comments · May be fixed by #600
Labels
[Block] Header & Footer Low Priority This should happen sometime, but other things are more important

Comments

@StevenDufresne
Copy link
Contributor

Originally reported in: https://meta.trac.wordpress.org/ticket/6478

When logged in to your WordPress account, user names in the Admin toolbar are linked to the edit profile page.

@jakariaistauk337 suggests that the first 2 username links should go to https://profiles.wordpress.org/{username}/. There is already an "Edit Profile" link that navigates appropriately.

@ryelle ryelle added the Low Priority This should happen sometime, but other things are more important label Sep 13, 2022
@dionysous
Copy link

dionysous commented Feb 12, 2024

I didn't know what components were involved at first, so I had created this Meta-Trac ticket: https://meta.trac.wordpress.org/ticket/7462 I had the same idea as @StevenDufresne and think it's important that this is discussed.

Description

The admin bar dropdown for logged in users has redundancy in its navigation links. The intent of this ticket is to suggest an improvement to the user interface by altering one of the "Edit Profile" links to a "View Profile" link. This modification promises to improve the navigation experience by allowing users to swiftly access their public profile directly from the admin bar.

Current Interface

  • The username in the admin bar's top-right corner navigates to the Edit Profile page.
  • Hovering over the username reveals the dropdown menu, which includes:
    • "Howdy, ((displayname))" redirects to the Edit Profile page.
    • "((username))" combined with "((displayname))" redirects to the Edit Profile page.
    • "Edit Profile" leads to the same Edit Profile page.
    • "Log Out" leading to the logout process.

Alternative Proposed Interface Enhancement (v1)
wp org-admin-bar

Proposed Interface Enhancement

  • The username in the admin bar's top-right corner continues to navigate to the Edit Profile page.
  • Hovering over the username still displays the dropdown menu, but with a more intuitive link setup:
    • "Howdy, ((displayname))" maintains its redirection to the Edit Profile page.
    • "((username))" alongside "View Profile" now directs to the View Profile page.
    • "Edit Profile" remains unchanged, leading to the Edit Profile page.
    • "Log Out" continues to facilitate the logout process.

Challenges

  • On wordpress.org, there is always a publicly visible profile. There, the "View Profile" link should always be present.
    • For example, I often use my profile to check my photo uploads in the directory. Since all three links currently lead to "Edit Profile," one must navigate further from there, which is cumbersome.
  • Changing the dropdown menu could initially lead to slight confusion among the WordPress community. However, this can be prevented with clear link labels.

Affected code

/**
* Filter the admin bar links to simplify the frontend view.
*
* @param \WP_Admin_Bar $wp_admin_bar The WP_Admin_Bar instance, passed by reference.
*/

Reference

@dionysous
Copy link

dionysous commented Feb 12, 2024

I would like to agree with @StevenDufresne and suggest changing the first 2 links:

Alternative Proposed Interface Enhancement (v2)
wp org-admin-bar2

@StevenDufresne
Copy link
Contributor Author

That does make sense to me, although I feel like that collapsed menu should display Howdy, {username} and keep the display name above view profile.

I'm basing that on the fact that the display name isn't a clear indication of what account your are accessing, so seeing it collapsed will be beneficial in the future for other wp.org functions (password resets, etc...) and when you arrive on your profile page, you immediately see your display name as the largest landmark next to your image which should match what you see in the dropdown, so there's a flow connection there as well.

It isn't a strong opinion though, i think either change is an improvement we could make for wp.org.

@dionysous
Copy link

dionysous commented Feb 13, 2024

I agree with you. It would just be important to me to show both the user name and the display name, as is currently the case. No matter how it is displayed, there is no question in my mind that we need View Profile linking and it would simplify navigation enormously.

Alternative Proposed Interface Enhancement (v3):
wp org-admin-bar3

@dd32
Copy link
Member

dd32 commented Apr 11, 2024

These items are default core objects, not customised for WordPress.org at present.

This has changed slightly since this issue was opened, as it appears to have changed in core. WordPress/wordpress-develop@eb33c60 WordPress/wordpress-develop@44c41a5

There's no longer a separate Edit Profile link, that's merged with the Avatar.

See the PR below for a change that reflects the above suggestions.

@dd32
Copy link
Member

dd32 commented Apr 11, 2024

I feel like that collapsed menu should display Howdy, {username} and keep the display name above view profile.

I'm basing that on the fact that the display name isn't a clear indication of what account your are accessing, so seeing it collapsed will be beneficial in the future for other wp.org functions

In the same manner, the username might not be clear as to which account you're using for some users. I don't personally think we should be displaying the username here, as that's less human than the chosen display name IMHO..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Header & Footer Low Priority This should happen sometime, but other things are more important
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants