Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin directory: Sentence case for secondary navigation items #318

Closed
jasmussen opened this issue May 14, 2024 · 4 comments
Closed

Plugin directory: Sentence case for secondary navigation items #318

jasmussen opened this issue May 14, 2024 · 4 comments

Comments

@jasmussen
Copy link

Related to WordPress/wporg-theme-directory#55

We should standardize on sentence case for navigation items across secondary navigation.

In the case of the plugin directory, it relates to these items:

Image

They should be updated to say:

  • My favorites
  • Submit a plugin (already okay)
@jasmussen
Copy link
Author

@ryelle apologies, I believe I opened this issue in the wrong repo. If you can help move it, I'd appreciate it 🙏

@jasmussen jasmussen changed the title Sentence case for secondary navigation items Plugin directory: Sentence case for secondary navigation items May 14, 2024
@ryelle ryelle transferred this issue from WordPress/wporg-mu-plugins May 14, 2024
@dd32
Copy link
Member

dd32 commented May 15, 2024

Should the Section remain named as My Favourites on the homepage and section header? It's just the Navigation that should have lower-case correct? ( This probably needs translation context, _x( 'My favorites', 'navigation menu', 'wporg-plugins' ) to differentiate it.)

Homepage Header
Screenshot 2024-05-15 at 1 20 18 PM Screenshot 2024-05-15 at 1 21 12 PM

@jasmussen
Copy link
Author

Ideally we unify our use of sentence case, OR title case, for menu items and headings, across the entire site and all contexts. I lean towards sentence case, as that appears to be used the most, but really it's about the consistency. Most near term, however, it's just important to unify the menu item so it's the same across plugin, pattern and theme directories.

@ryelle
Copy link
Contributor

ryelle commented May 15, 2024

We have already decided that we're unifying on sentence case, so yes, I'd update that on these headings as well.

bazza pushed a commit that referenced this issue Jun 4, 2024
See: #318
Props: joen, ryelle, dd32


git-svn-id: https://meta.svn.wordpress.org/sites/trunk@13765 74240141-8908-4e6f-9713-ba540dce6ec7
@bazza bazza closed this as completed in 6f7c6e0 Jun 4, 2024
bazza pushed a commit that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants