Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Audit whether I18n domains are handled correctly everywhere #758

Open
jrfnl opened this issue Jul 4, 2022 · 2 comments
Open

[Task] Audit whether I18n domains are handled correctly everywhere #758

jrfnl opened this issue Jul 4, 2022 · 2 comments

Comments

@jrfnl
Copy link
Member

jrfnl commented Jul 4, 2022

Verify whether there are any code paths which could be reached where an international (multi-byte) domain would not have been translated to its ASCII value yet and non-multibyte-safe functions are being used.

This audit should, of course, safeguard this for the future with additional integration tests if/when needed.

Note: this audit should only verify this for the officially supported API. Not officially supported entry points can be disregarded.

@schlessera
Copy link
Member

I don't think this only concerns domain handling. I think we'd need to do a full audit of the string-handling in Requests to ensure it handles multi-byte characters gracefully and appropriately everywhere. In some instances, this means properly discarding multi-byte characters upfront, because whatever RFC/standard/protocol disallowing their use.

In some instances, we need to have them properly pass through the string handling without causing invalid characters and random mismatches because of bad truncation of MB characters.

@jrfnl
Copy link
Member Author

jrfnl commented Jul 4, 2022

Also #759 (duplicate)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants