New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: review all tests to stabilize them more #497
Comments
jrfnl
changed the title
Test: review all tests to stabalize them more
Test: review all tests to stabilize them more
Jun 18, 2021
I've updated the issue description to contain a list of additional tasks and an action list so we can keep track of the status of this mini-project. We'd welcome more people to get involved in this review. If you want to take any of these classes on, just leave a comment to "claim" it and I'll update the above list. |
This was referenced Sep 17, 2021
Merged
This was referenced Apr 25, 2022
This was referenced May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, there are a lot of tests which follow a pattern along the lines of:
Tests like these are unstable as they may error out on any of the following:
$result
not being an array.'key'
index not existing in$result
'subkey'
index not existing in$result['key']
$result['key']['subkey']
not being an object$result['key']['subkey']
not being an object of the expected type (instance of)$result['key']['subkey']
not having a property named$property
.Those tests should be stabilized and improved by changing them to something along the lines of:
Additionally, all tests which have multiple assertions, should pass the
$message
parameter to each assertion to help figure out which assertion has failed when a test fails.Other review tasks (optional, but highly recommended)
@covers
tags.Actions list
Requests\Tests\ChunkedEncodingTest
- PR ChunkedEncodingTest: improve tests #581Requests\Tests\CookiesTest
- PR series, PR Cookie\UriMatchesTest: improve and stabilize #737Owner: @jrfnl
Status: Ready, waiting to be pulled
Requests\Tests\EncodingTest
- PR DecompressionTest: improve tests #595Requests\Tests\IdnaEncoderTest
- PR IdnaEncoderTest: improve tests #549Requests\Tests\IriTest
Requests\Tests\RequestsTest
Requests\Tests\SessionTest
Owner: @jrfnl
Status: WIP
Requests\Tests\SslTest
- PR Ssl: improve tests #551Requests\Tests\Auth\BasicTest
- PR Auth\Basic: improve tests #557Requests\Tests\Cookie\JarTest
- PR Cookie\Jar tests: stabilize and improve #734Requests\Tests\Proxy\HttpTest
Requests\Tests\Response\HeadersTest
- PR Response\Headers: improve tests #555Requests\Tests\Transport\BaseTestCase
Requests\Tests\Transport\CurlTest
Requests\Tests\Transport\FsockopenTest
Requests\Tests\Utility\FilteredIteratorTest
- PR FilteredIteratorTest: improve tests #550Status: basic review done, could use more improvements and additional tests.
The text was updated successfully, but these errors were encountered: