Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test infrastructure #496

Open
schlessera opened this issue Jun 18, 2021 · 1 comment
Open

Improve test infrastructure #496

schlessera opened this issue Jun 18, 2021 · 1 comment

Comments

@schlessera
Copy link
Member

Most of the tests right now are doing remote requests against a custom server running on Heroku: https://requests-php-tests.herokuapp.com.

These remote requests are flaky as they tend to fail every once in a while.

To improve on that (and get most of the global networking stack out of the equation), we should look at pulling up a testing server within the GitHub Actions environment. In this way, the network requests would run internally within that virtualized environment, and the probability for failure is much lower.

As a bonus, we could also check whether there are any other uses of the Heroku app that we're unaware of. Maybe @rmccue can get a hold of the access logs?

@rmccue
Copy link
Collaborator

rmccue commented Jun 18, 2021

I don't think there's any logs available, but the problem is likely because the Heroku dynos can take a few minutes to spin up.

The main problem with running in a fully virtualised environment that I found was that for things like the proxy tests, it wasn't an accurate test of the actual system. Running a proper local setup with a real server like nginx might fix the problems I saw.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants