Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CI #1

Open
seanamosw opened this issue Aug 29, 2018 · 3 comments
Open

Setup CI #1

seanamosw opened this issue Aug 29, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@seanamosw
Copy link
Collaborator

@StefH I don't have admin access to the repo so I can't setup a CI pipeline.

@seanamosw seanamosw added the enhancement New feature or request label Aug 29, 2018
@StefH
Copy link
Contributor

StefH commented Aug 29, 2018

You did already have write access to this project:
afbeelding

About the CI pipeline, I use AppVeyor for that.
Maybe I can create and configure the AppVeyor project for you (@ AppVeyor site) and give you access?

And do you already have some code to add to this project ?

@seanamosw
Copy link
Collaborator Author

There is an initial implementation on the develop branch.
I would probably want to use TravisCI as the integration tests run using Linux docker containers.

@StefH
Copy link
Contributor

StefH commented Aug 29, 2018

Maybe you can just a Pull Request to master and add me as reviewer. So that I can review your code so that the code aligns with the main project.

BTW : I see that you use paket, personally I never used this because it's not needed anymore because you can create a NuGet using the csproj now ?

And the project does now only support netstandard2.0, can you change that to support the same frameworks as the main project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants