New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis CI examples deployment isn't working #317
Comments
has it ever worked automatically? I don't see the deploy step for examples. before_deploy:
- gulp examples:build
- gulp docs --all
...
deploy:
provider: surge
project: ./
domain: whs-dev.surge.sh
skip_cleanup: true
on: dev
deploy:
provider: surge
project: ./docs/public/
domain: whsjs.io
skip_cleanup: true
on:
branch: master
tags: true |
Also, I propose we do this as part of this issue:
deploy:
provider: surge
project: ./examples
domain: whs-master.surge.sh
skip_cleanup: true
on: master Otherwise some newer examples not supported yet by released version might be tried and would not work on the pulled dependency by users. would be confusing. |
@hirako2000 I completely agree on that why. I still can't figure out why dev examples are not pushing to surge. (something happened, while nothing was touched) |
this is a change, it was touched. maybe we can't have multiple deploy steps with same provider: diff. I suggest we do this below, as documented here, and using Travis env variables for conditional branch deployment. after_success:
- test $TRAVIS_BRANCH = "dev" && surge --project ./ --domain whs-dev.surge.sh
- test $TRAVIS_BRANCH = "master" && surge --project ./ --domain whs-master.surge.sh
- test $TRAVIS_BRANCH = "master" && surge --project ./docs/public/ --domain whsjs.io |
Travis CI examples deployment isn't working.
Version:
Issue type:
Tested on:
Desktop
Android
IOS
The text was updated successfully, but these errors were encountered: