Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert existing Sveltekit Application to Webstone plugin/app #399

Open
Cahllagerfeld opened this issue Aug 13, 2023 · 3 comments
Open

Convert existing Sveltekit Application to Webstone plugin/app #399

Cahllagerfeld opened this issue Aug 13, 2023 · 3 comments

Comments

@Cahllagerfeld
Copy link
Member

Cahllagerfeld commented Aug 13, 2023

Things to clarify:

  • Do we want to handle this inside create-webstone-app, or do we want to have this as part of the cli for example
@mikenikles
Copy link
Collaborator

Do we want to handle this inside create-webstone-app, or do we want to have this as part of the cli for example

I would add it to create-webstone-app, but only to convert a SvelteKit lib package into a Webstone plugin. I think we no longer have a concept of converting a SvelteKit app into a Webstone app, do we?

I see 3 use cases for create-webstone-app:

  1. To create a new app
  2. To create a new plugin
  3. To convert a SvelteKit lib package into a Webstone Plugins package.

If a user runs npm create webstone-app without any --type flag, we check if the current directory is an existing SvelteKit lib package and if so, ask the user if they want to convert it. We can determine that if the package.json contains a package script.

@Cahllagerfeld
Copy link
Member Author

How would the signature of our create-webstone function that we expose through code look like? Would it be a flag, or should the check be done automatically?

@mikenikles
Copy link
Collaborator

My first instinct is to make it a parameter. It's likely the easier approach and less magic happens from the eyes of the developer who wants to integrate it into their code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants