-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faraday 1.x can bypass Diplomat::QueryAlreadyExists #227
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Faraday 1 made changes to the
Faraday::ClientError
, introducingFaraday::ServerError
(https://github.com/lostisland/faraday/blob/main/UPGRADING.md#errors)This split the errors, with client errors now responsible for 4xx codes and server errors for 5xx codes.
The
Diplomat::Query#create
method only expects/handles client errors. As such, (some) errors that were previously caught and reported asDiplomat::QueryAlreadyExists
, now raiseFaraday::ServerError
.The text was updated successfully, but these errors were encountered: