Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time picker flow doesn't work after complete #864

Closed
faizaaulia opened this issue May 13, 2024 · 1 comment
Closed

Time picker flow doesn't work after complete #864

faizaaulia opened this issue May 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@faizaaulia
Copy link

Describe the bug
I use the time picker mode & set the flow to [hours, minutes], then I conditionally set the flow value based on the time picker value & what overlay is being opened. When the first flow is being proceed for the first time, the flow is working properly. On my case, it will directly open the hours overlay, then the minutes overlay. But after it, if I open the hours overlay again, it doesn't move to the minutes overlay

To Reproduce
Steps to reproduce the behavior:

  1. Go to Reproduction
  2. Click the input, it will open the hours overlay directly
  3. Pick an hour, then it will open the minutes overlay
  4. Pick a minute, then it will close the minutes overlay and back to the time overlay (display with hours, minutes, and up & down button)
  5. Click the hours button, then pick an hours

Expected behavior
After the step 5, the expected behavior is to open the minutes overlay, because the flow is still [hours, minutes]

Screenshots
https://github.com/Vuepic/vue-datepicker/assets/21327758/66a798d8-6a45-4b47-a3cf-4065ff3999cd

Desktop & mobile (please complete the following information):

  • Browser [e.g. chrome, safari]
  • Library version: 8.6.0
@faizaaulia faizaaulia added awaiting triage The issue is not reviewed by the maintainers bug Something isn't working labels May 13, 2024
@Jasenkoo
Copy link
Contributor

This is expected behavior, because flow is only triggered on the mount. I'll expose a method to re-trigger it.

@Jasenkoo Jasenkoo added enhancement New feature or request and removed bug Something isn't working awaiting triage The issue is not reviewed by the maintainers labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants