Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-F12 (GoToImplementation) puts VsVim into visual mode #2966

Open
2 tasks
artemoks opened this issue Mar 4, 2022 · 10 comments · May be fixed by #3096
Open
2 tasks

Ctrl-F12 (GoToImplementation) puts VsVim into visual mode #2966

artemoks opened this issue Mar 4, 2022 · 10 comments · May be fixed by #3096

Comments

@artemoks
Copy link

artemoks commented Mar 4, 2022

Describe the bug
GoToImplementation puts VsVim into the visual mode.

To Reproduce
Steps to reproduce the behavior:

  1. Set a cursor on a symbol
  2. Ctrl+F12
  3. VS jumps to the implementation and VsVim enters the visual mode

Expected behavior
VsVim should stay in the command mode

Screenshots

Environment (please complete the following information):

  • Visual Studio version: Microsoft Visual Studio Enterprise 2022 (64-bit) - Current
    Version 17.1.0
  • VsVim version: 2.10.0.5
  • Programming Language: C#
  • Check(Type 'x') any that are installed:
    • ReSharper
    • Visual Assist

Additional context
Add any other context about the problem here.

Note:
The following is written about contributing.
https://github.com/VsVim/VsVim/blob/master/CONTRIBUTING.md

General Keyboard configuration problems are described below.
#2527
@mrubelmann
Copy link

I've run into this in VS 2022 as well. It looks like it used to be a problem, was fixed, and has now come back: #1963

@mezdelex
Copy link

Definitely a problem I'm experiencing as well in VS2022.

@TomMalitz
Copy link

I am also experiencing this issue in VS2022.

@hkleynhans
Copy link

Also experiencing this is VS2022.

@vcfvct
Copy link

vcfvct commented Jun 1, 2023

Same here, quite annoying. seems to be happening a while ago at #1963 ?

@hkleynhans
Copy link

Happening in C++ as well with Visual Assist.

@coderguy57
Copy link

coderguy57 commented Jun 14, 2023 •
edited

Same here. Is there no way of making a mapping that exits the visual mode?
Something like this:
:map gd :vsc Edit.GoToDefinition<CR><ESC>
It doesn't work, but I guess the problem is that it presses ESC before it have gone to the definition.
This could have been an ugly solution, but it doesn't seem like VsVim support :sleep
:map gd :vsc Edit.GoToDefinition<CR>:sleep 100ms<ESC>

@ghost
Copy link

ghost commented Jun 16, 2023

Same experience with C++ project editing

@jackhub
Copy link

jackhub commented Aug 23, 2023

I am also experiencing this issue in VS2022.

@asuper0
Copy link

asuper0 commented Sep 21, 2023

I am also experiencing this issue in VS2022, but only with C++. The C# project works well.

nosami added a commit that referenced this issue Mar 10, 2024
@nosami
Unwanted selections don't switch to Visual Mode
17d42e9 
I'm not sure if this behavior is ever desirable, but created this
PR anyway so that we can discuss.

I don't see any downsides from doing this. Visual mode works from
key input and mouse selections. We just don't automatically switch
to Visual Mode when Visual Studio decides that it wants to select some
text for us by itself.

Fixes #2966
@nosami nosami linked a pull request Mar 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unwanted selections don't switch to Visual Mode VsVim/VsVim
9 participants
@mrubelmann @vcfvct @hkleynhans @jackhub @TomMalitz @asuper0 @mezdelex @coderguy57 @artemoks