Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying on Lenovo Thinkpad L390 with OpenCore #42

Open
antoniomcr96 opened this issue Jun 28, 2020 · 10 comments
Open

Trying on Lenovo Thinkpad L390 with OpenCore #42

antoniomcr96 opened this issue Jun 28, 2020 · 10 comments

Comments

@antoniomcr96
Copy link

I'm trying to make the touchpad work better on Lenovo Thinkpad L390, that should have this SMBus.
I'm booting with open core. I followed this #20 (comment) post, and applied the patches.

  1. It doesn't seem to work;
  2. If I delete /Contents/Plugins/VoodooPS2Mouse.kext and its entry in OC config.plist keyboard and trackpad and trackpoint don't work
  3. Where do I have to apply this in Opencore? https://github.com/VoodooSMBus/VoodooSMBus/blob/master/config.plist.patch
    Thanks in advance to everyone!
@DeveloperEN
Copy link

Hi, I am having the exact same issue with the same model. It's seems like it's about the kext rather than our fault, so all you can do is just wait for the dev @leo-labs to have a look at it and provide logs if needed. If you have already followed #20 , you don't have to worry about "config.plist.patch" since you already have blocked the Apple's kexts. You can use ELANSMBus instead of this kext until the developer fixes the issue.
Please note that you still have to block Apple's own kexts and disable PS2Mouse kext in order to use that.

@antoniomcr96
Copy link
Author

Hi, I am having the exact same issue with the same model. It's seems like it's about the kext rather than our fault, so all you can do is just wait for the dev @leo-labs to have a look at it and provide logs if needed. If you have already followed #20 , you don't have to worry about "config.plist.patch" since you already have blocked the Apple's kexts. You can use ELANSMBus instead of this kext until the developer fixes the issue.
Please note that you still have to block Apple's own kexts and disable PS2Mouse kext in order to use that.

Thanks! I would suggest also: [Kext] Elan PS/2 touchpad new kext: github.com/BAndysc/VoodooPS2/releases/tag/elanps2.v1
I’m giving a hand to the developer with some debugging and everything works well atm.
Sorry for the OT: do you have L390? Did you manage to 1. Install on internal drive (PM981) and 2. Make sleep work? Thanks!

@DeveloperEN
Copy link

DeveloperEN commented Jul 4, 2020

I know about the kext and currently working with the developer as a tester, too. I have a PM960 which works just fine but since I have already disabled sleep I can't tell you much about that unfortunately.

Edit: Bandy's implementation is really glitchy and suffers from interruption issues. You may use that right now but I highly recommend waiting for this kext to be fixed since it's more well-rounded. I know that Bandy is trying to fix the issues and implement physical button support but it seems like it's gonna take a while.

@gokula
Copy link

gokula commented Jul 5, 2020

Hi,
can you test the VoodooSMB.kext included in this repo. https://github.com/gokula/T480s-EFI ?
It is the version working for me using Opencore/Mojave and works better than the ELANSMBus one.

@antoniomcr96
Copy link
Author

No problem. At the moment everything works well with VoodooPS2 by BAndysc but if you want I can try.
What do I need to do? Stock VoodooPS2Controller and VoodooSMBUS kext in your EFI folder? Do I need any patch ?

@gokula
Copy link

gokula commented Jul 5, 2020

I guess it should work better than the PS2 version, so it might be worth trying.

Regarding the patch, I do not use any, but while trying make it work I don't remember If I just removed the conflicting kexts or I changed the permissions so they are not used.

@DeveloperEN
Copy link

@gokula It works! Better than ELAN. I still don't know why the original version doesn't tho. Weird.

@leo-labs
Copy link
Member

leo-labs commented Jul 7, 2020

Which was the original version you have used? If you have used the one from the Releases, that does not include the OpenCore fix. There has not been a release for that.

@leo-labs
Copy link
Member

leo-labs commented Jul 7, 2020

I have done one last release for the v2.x version that adds support for OpenCore. Please try it out: https://github.com/VoodooSMBus/VoodooSMBus/releases/tag/v2.2 and let me know if this fixes your problem.

@antoniomcr96
Copy link
Author

Thanks.

  1. Removed my previous VoodooPS2Controller
  2. Installed VoodooPS2Controller by Acidanthera
  3. Put the patch inside config.plist
  4. Installed VoodooSMBus that should load after VoodooInput, VoodooPS2Mouse, VoodooPS2Keyboard, and VoodooPS2Trackpad
    For me it doesn’t work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants