Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chart Generation] 图表生成支持传入VChart主题 #104

Open
da730 opened this issue May 7, 2024 · 3 comments
Open

[Chart Generation] 图表生成支持传入VChart主题 #104

da730 opened this issue May 7, 2024 · 3 comments
Labels
Milestone

Comments

@da730
Copy link
Contributor

da730 commented May 7, 2024

  1. 内置几套常见的VChart主题和图表助手主题:https://www.visactor.io/vchart/theme/playground
  2. VMind.generateChart接口,支持传入theme参数
  3. 图表生成pipeline将theme应用到图表spec上
  4. 修改默认的主题样式
@da730 da730 self-assigned this May 7, 2024
@da730 da730 added this to the Iteration 16 milestone May 7, 2024
@da730 da730 changed the title [Open API] Optimize VChart Theme to support more configs [Chart Generation] 图表生成支持传入VChart主题 May 14, 2024
@da730 da730 modified the milestones: Iteration 16, Iteration 17 May 22, 2024
@MaxtuneLee
Copy link
Contributor

MaxtuneLee commented May 28, 2024

似乎与目前已有的功能有一部分功能重合

https://github.com/VisActor/VMind/blob/d4e0d4e7c1164c0ba01f70e8ba7f457b6f903c87/packages/vmind/src/core/VMind.ts#L126C31-L127C1

如果同时传入 theme 和 ColorPalate 参数如何处理呢

@da730
Copy link
Contributor Author

da730 commented May 28, 2024

似乎与目前已有的功能有一部分功能重合

https://github.com/VisActor/VMind/blob/d4e0d4e7c1164c0ba01f70e8ba7f457b6f903c87/packages/vmind/src/core/VMind.ts#L126C31-L127C1

如果同时传入 theme 和 ColorPalate 参数如何处理呢

以theme为准,colorPalette参数只影响图表的配色(spec.colors),theme除此之外还会影响label样式、图例样式、背景色等

@da730 da730 removed their assignment May 28, 2024
@Abyseas
Copy link

Abyseas commented May 31, 2024

请问这个issue有人认领吗,没人的话我想认领一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants