-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetricsQL: Document stalness marker differences between default_rollup
and last_over_time
#6279
Comments
1 task
hey @michalhosna |
hagen1778
pushed a commit
that referenced
this issue
May 17, 2024
Thanks for reporting @michalhosna! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From the current(2024-05-15) MetricsQL documentation, it seems that the
default_rollup
andlast_over_time
functions are effectivly the same.Even looking into the code, those functions seem the same
VictoriaMetrics/app/vmselect/promql/rollup.go
Line 2328 in 5e8c087
But there are somewhat hidden differences at minimum with staleness marker handling, which are non-obvious
VictoriaMetrics/app/vmselect/promql/eval.go
Line 1972 in 5e8c087
Those differences, as well as any other differences, should be documented in the MetricsQL documentation.
The text was updated successfully, but these errors were encountered: