Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete items and folders with bitwarden-web v1.24.0 #27

Open
leonghui opened this issue Mar 24, 2018 · 7 comments · May be fixed by #41
Open

Unable to delete items and folders with bitwarden-web v1.24.0 #27

leonghui opened this issue Mar 24, 2018 · 7 comments · May be fixed by #41

Comments

@leonghui
Copy link

leonghui commented Mar 24, 2018

Deleting an existing item appears to work but upon refresh, the item still exists. Same behaviour when deleting folders.

Server stdout reports:
2018/03/24 04:32:25 [email protected] is trying to edit his data
2018/03/24 04:32:25 strconv.ParseInt: parsing "67/delete": invalid syntax
...
2018/03/24 04:37:57 [email protected] is trying to update a folder
2018/03/24 04:37:57 Folder 423b3f90-46ee-448d-adb0-a9f47edcef89/delete updated

EDIT:
Other clients (tested: Android app 1.51.1, Firefox extension 1.25.4):
Item deletion works fine. Folder deletion is broken, deleted folders reappear after sync.

Server stdout for other clients:
2018/03/24 04:48:23 [email protected] is trying to edit his data
2018/03/24 04:48:23 Cipher 68 deleted
...
2018/03/24 04:50:05 [email protected] is trying to update a folder

@Odysseus16
Copy link

I have also implemented the new API. So if you want, you can try my version (but at the moment the database is not compatible with VictorNines.
I plan to submit a pull request in the next time, but as I have done major changes it is hard to make my branch compatible with VictorNines.

@leonghui
Copy link
Author

@Odysseus16
Thanks for your work, I am looking forward to Totp support but I will need to migrate my data over to your build for testing.

@VictorNine
Issue above still exists after 17c1ff3 (tested: Android app 1.51.2, Firefox extension 1.25.7, and bitwarden-web 1.25.1)

@timreuscher
Copy link

@Odysseus16 Does your fork support Match Detection yet? I know this one doesn’t.

@VictorNine
Copy link
Owner

VictorNine commented Apr 12, 2018 via email

@timreuscher
Copy link

timreuscher commented Apr 12, 2018

@VictorNine My bad. It does work after the update. I made the change in the web vault but hadn’t synced it to my browser add-on. Appreciate the work on this.

@VictorNine
Copy link
Owner

Good to hear. I'll look in to the folders as well

@davehope
Copy link

davehope commented Apr 8, 2019

@VictorNine, did you ever get to look at the folder deletion issue?

@davehope davehope linked a pull request Apr 14, 2019 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants