Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APC] Add a function to reduce repetition in the pingset red|orange|green commands #56

Open
Vexed01 opened this issue Oct 26, 2021 · 0 comments
Labels
approved I'll be implementing this soon cog: apc Relating to the AnotherPingCog cog type: enhancement New feature or request
Milestone

Comments

@Vexed01
Copy link
Owner

Vexed01 commented Oct 26, 2021

What cog is this feature request for?

AnotherPingCog

Describe the feature request in as much detail as possible

There is a lot of code repetition in pingset red, pingset orange and pingset green in anotherpingcog.py. This could be cleaned up and made easier to maintain by adding a function which is called by all three.

This is one of my Hacktoberfest issues, which anyone may take without needing to ask me directly, and if not done I will get around to doing them in the coming months.

@Vexed01 Vexed01 added type: enhancement New feature or request cog: apc Relating to the AnotherPingCog cog hacktoberfest approved I'll be implementing this soon labels Oct 26, 2021
@Vexed01 Vexed01 added this to the Long term milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved I'll be implementing this soon cog: apc Relating to the AnotherPingCog cog type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant