Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Font is Uniform Across Pages #407

Closed
Cameron-Porter opened this issue Jun 22, 2022 · 2 comments · May be fixed by #446
Closed

Ensure Font is Uniform Across Pages #407

Cameron-Porter opened this issue Jun 22, 2022 · 2 comments · May be fixed by #446

Comments

@Cameron-Porter
Copy link
Contributor

Describe the bug
Ensure font is uniformly applied to the app. It seems it is not fully covering the Apply -> Mentor page.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Apply
  2. Click on Mentor
  3. Scroll down to view different fonts displayed on the page

Expected behavior
Expect the Gotham font to be applied to as per other pages in the app.

@Takomane
Copy link
Contributor

Takomane commented Jul 3, 2022

I may be misreading, or need new glasses and cannot tell the difference, but each individual class Inherits from body. When I inspect the page and look at each element the styles has:

body, h1, h2, h3, h4, h5, h6 {
font-family: Gotham,sans-serif;
}

@stephanlamoureux
Copy link
Contributor

@Takomane It does show that, but it's not displaying as such. I had to change the typed.js font by using inline styling.

<Typed
                    style={{ fontFamily: 'Gotham, sans-serif' }}
                    className="typedString"
                    strings={[
                      'RESULTS DRIVEN',
                      '100% ONLINE',
                      'LEARN PRAGMATICALLY',
                      'PREPARED FOR THE INDUSTRY',
                    ]}
                    typeSpeed={70}
                    backSpeed={80}
                    smartBackspace
                    loop
                  />

You can see here that in the podcast headers it's not using the Gotham font. I can't remember, but I think if you have Gotham installed locally it works everywhere as intended so it's not noticeable to everyone.

font

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants