Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform flags to flutter app template #630

Open
renancaraujo opened this issue Jan 23, 2023 · 6 comments
Open

Add platform flags to flutter app template #630

renancaraujo opened this issue Jan 23, 2023 · 6 comments
Assignees
Labels
feature A new feature or request

Comments

@renancaraujo
Copy link
Contributor

Description
Derived from this comment: #467 (comment)

People want to use flags to specify which platform directories should be created when using

very_good create flutter_app
@renancaraujo renancaraujo added the bug Something isn't working as expected label Jan 23, 2023
@superiorsd10
Copy link
Contributor

Hello @renancaraujo 👋
I hope you're doing well. I'd like to contribute to the very_good_cli and noticed that there's this open issue. Would it be possible to assign this issue to me? I'd be happy to work on it.

Thank you,

@renancaraujo
Copy link
Contributor Author

Hello @superiorsd10 ,
Of course, I am happy to assign this to you.

But please keep in mind that this is not a beginner-friendly issue, as there are changes that should be made on some templates (flame game, wear os, and very good core) before any change is made on the CLI itself.

@superiorsd10
Copy link
Contributor

Hello @renancaraujo 👋
I've been working on this issue for the past few days, and that's how I'm approaching it:-

  1. Added an addMultiOption for the platforms to the argParser in the flutter_app.dart.
  2. Stored the specified platforms by the user in the vars map in the getTemplateVars function in the flutter_app.dart.
  3. Added the platforms in the very_good_core_bundle.dart.

Still it's not working out.

Another thing that I've come across while working on this issue is that, there are no files available for the macos and linux platforms in the veryGoodCoreBundle in the very_good_core_bundle.dart.

So, can you please help in guiding through it?

@renancaraujo
Copy link
Contributor Author

Hello @superiorsd10,

As described on the contributing guide, the templates have their own repository (linked above in my comment). Then after the changes are released to brickhub, we bundle them to the CLI.

@renancaraujo renancaraujo added the waiting for response Waiting for follow up label Oct 11, 2023
@superiorsd10
Copy link
Contributor

Hello @superiorsd10,

As described on the contributing guide, the templates have their own repository (linked above in my comment). Then after the changes are released to brickhub, we bundle them to the CLI.

Okay, so you mean that it's not really enough to change only the lib folder code to test the code (manually)? Am I understanding it right?

Also, there are no files for macos and 'linux' in the core app bundle.

@alestiago
Copy link
Contributor

alestiago commented Oct 13, 2023

Hi @superiorsd10 ! Thanks for asking all these questions! I'm looking forward to your contributions 💙 !

Okay, so you mean that it's not really enough to change only the lib folder code to test the code (manually)? Am I understanding it right?

This is a valid concern. If you think we're missing some information within the CONTRIBUTING let us know. In a nutshell, "templates (the code that gets generated per create command) have their own repositories, if you want to contribute to them please refer to their repositories".

If you checkout to a template repository and would like to generate the code locally you would have to use mason (the templating generator we use). They have an official documentation site. Mason templates can be passed variables that change the output, see the variables accepted by the latest Very Good Core template and those can be populated via Very Good CLI (acting as a proxy for create commands).

Once a template changes, we (maintainers) would make sure to publish a new version and update Very Good CLI , where necessary, to use such.

Also, there are no files for macos and 'linux' in the core app bundle.

There is an open issue about providing support to these platforms #452. There is a comment with further instructions there if you wish to contribute 🙌

@alestiago alestiago added waiting for response Waiting for follow up feature A new feature or request and removed waiting for response Waiting for follow up bug Something isn't working as expected labels Oct 13, 2023
@BeatriceMitchell BeatriceMitchell removed the waiting for response Waiting for follow up label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request
Projects
Status: Community
Development

No branches or pull requests

4 participants