-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application ID does not appear in Android files (AndroidManifest and MainActivity) #1035
Comments
Hi @icodeyou thanks for opening an issue 💙 ! I've been able to reproduce this in very_good_cli @TofferJ are you able to reproduce and verify the need of this change? Currently the manifest package name is intended to be |
The application ID should not be in the AndroidManifest or the MainActivity class. It resides in the build.gradle file, as @alestiago mentioned above. It is only used to identify your application in the Play Store. The package name in the AndroidManifest is what dictates the directory structure of your code. It is what you should see in package definition in e.g. the MainActivity class. It is perfectly fine for the two to be different. The package name can be changed at any time, but the application ID can not be changed once your app has been published. You could argue that it might be expected, or nicer, to have them both be the same after initializing the project. Personally, I think that having different default values helps people understand that they are not one and the same. I would recommend keeping things as is for now, but continue to monitor any feedback related to their default values. |
I see. It is good to know that it has no impact on the way it is identified by the Play Store. I still prefer to have a package name identical to the application ID, because I believe it is what is done by default when you create an native Android project. I think it would be great to keep things as closely as the way it is for most projects. By the way, when we create a project with |
Description
When we create a project, the argument
--argument-id
is not used in several Android config files.Steps To Reproduce
Create a Flutter project with the command :
very_good create flutter_app foo --application-id com.foo.app
Open the files :
foo/android/app/src/main/AndroidManifest.xml
foo/android/app/src/debug/AndroidManifest.xml
foo/android/app/src/profile/AndroidManifest.xml
foo/android/app/src/main/kotlin/com/foo/MainActivity.kt
Check the package names in those files
Start again with the command :
very_good create flutter_app foo --org com.foo --application-id com.foo.app
Expected Behavior
The package name must be :
com.foo.app
But it is instead :
com.example.verygoodcore.foo
orcom.foo.foo
Screenshots
The text was updated successfully, but these errors were encountered: