Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use analyzer to check for compile errors before completing sucessfully #1301

Open
4 tasks
a-wallen opened this issue Feb 26, 2024 · 1 comment
Open
4 tasks
Labels
feature A new feature or request p1 High-priority issues at the top of the work list product: cli Issues related to the Dart Frog CLI

Comments

@a-wallen
Copy link

Description

Right now if you call dart_frog build with code that doesn't compile, it will still build the project.

Requirements
I am requesting that the default behavior be:

  • Compile the project (use analyzer)
  • Check if there's compile errors.
  • If no compile errors output the project.
  • If compile errors, forward them to the command line.

Additional Context
If this is a good idea. I can submit a PR.

@a-wallen a-wallen added the feature A new feature or request label Feb 26, 2024
@alestiago alestiago added needs triage Issue requires triage product: cli Issues related to the Dart Frog CLI labels Feb 26, 2024
@tomarra
Copy link
Contributor

tomarra commented Mar 12, 2024

Hi @a-wallen 👋 Thanks for opening up this ticket.

We were able to reproduce this locally so we can move forward with making a fix here. In talking with the team it seems like adding a check during the pre-gen phase of the dart frog prod server brick would be the best place to get this check added in.

If you would be able to take a look at this and open a PR we can work to get it through the merge process. Thanks!

@tomarra tomarra added p1 High-priority issues at the top of the work list and removed needs triage Issue requires triage labels Mar 12, 2024
@alestiago alestiago added the waiting for response Waiting for follow up label Mar 15, 2024
@tomarra tomarra removed the waiting for response Waiting for follow up label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature or request p1 High-priority issues at the top of the work list product: cli Issues related to the Dart Frog CLI
Projects
Status: Todo
Development

No branches or pull requests

3 participants