-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Useless check or Waste of time #378
Comments
That is hack to allow a couple of async events to run before the functions returns. Could potentially be improved |
@rossengeorgiev Can you give an example of when this hack starts to work? My primitive tests show that this line can be safely removed. |
According to the origin commit 9ef8e5d it is to allow the client to be considered fully connected (on the backend i guess). I was getting disconnected when I tried to send message immediately after |
In file
steam/steam/client/__init__.py
Line 484 in 0a6d152
in method called
login
on line 569 we can see a useless check:this is useless because it is followed by a return string of this method:
And why we spend exactly 0.5 seconds, why, for example, not 0.25 or even 1 second?
The text was updated successfully, but these errors were encountered: