-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make EResult (or the full response) accessible in SteamAuthenticatorError. #357
Labels
Comments
That's a good point. Lines 469 to 470 in 061ca33
|
I can see if I have time to do a PR |
luckydonald
added a commit
to luckydonald-forks/steam
that referenced
this issue
Sep 28, 2021
Made one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So current situation is that stuff like
SteamAuthenticator(…).add()
can causeSteamAuthenticatorError
.For example,
Now that's a pretty easy to catch that error, telling the user to first have it log off the old instance, hence duplicate.
Just, we can't really distinguish those errors unless we do some ugly string stuff on that returned string.
This is obviously super prone to issues due to changes there, it would be way better to just include those fields in the exception.
The text was updated successfully, but these errors were encountered: