-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TensorView returned by Tensor::slice seems to be indexed from the original 0 #52
Comments
The following changes fix this. @emstoudenmire can you comment whether this is the right thing?
|
PS: seems this change breaks test_tensorview.C, so perhaps still something has to be done. |
I am still trying to wrap my head around this one regarding whether it's a problem with Range or with TensorView. At the moment I am thinking Range is ok and that the problem is that TensorView::operator()(x) plugs its argument directly into range_.ordinal(x) (apart from maybe converting x from an argument pack to a Range::index_type), which isn't the appropriate thing in this case. |
The following code returns 1.0, which is wrong.
The text was updated successfully, but these errors were encountered: