Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the duel to play by remaining time in Homepage #269

Open
nathanaelhoun opened this issue Apr 1, 2021 · 0 comments
Open

Sort the duel to play by remaining time in Homepage #269

nathanaelhoun opened this issue Apr 1, 2021 · 0 comments
Labels
enhancement New feature or request frontend Client side issue good first issue Good for newcomers

Comments

@nathanaelhoun
Copy link
Member

nathanaelhoun commented Apr 1, 2021

Is your feature request related to a problem? Please describe.

Currently, the duels to play are sorted by id on the Homepage.

Describe the solution you'd like

It would make more sense to sort them by remaining time, to have the more urgent ones at the top

This change should be pretty straightforward and only require a array sort before the rendering on HomePage.jsx.

If the sort takes too much performance for this page (unlikely), we could add it in the query treatment (in utils/) rather than the rendering component (in pages/).

@nathanaelhoun nathanaelhoun added enhancement New feature or request frontend Client side issue labels Apr 1, 2021
@nathanaelhoun nathanaelhoun changed the title Sort the duel to play by remaining time Sort the duel to play by remaining time in Homepage Apr 5, 2021
@nathanaelhoun nathanaelhoun added the good first issue Good for newcomers label May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Client side issue good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant