Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3179 #3180

Merged
merged 3 commits into from
May 8, 2024
Merged

Issue/3179 #3180

merged 3 commits into from
May 8, 2024

Conversation

craig8
Copy link
Contributor

@craig8 craig8 commented May 6, 2024

Description

This PR fixes issue #3179 by removing the PersistentDict from the admin_endpoint.py file. This file is responsible for initiating the creation of the web admin user. The syncing of the persistent dictionary to disk caused issues with the watchdog reloader.

This fix should be able to be merged with releases/8.2 branch

Fixes #3179

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tests are in the process of running, and have run locally in order to verify the expected results.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

@craig8 craig8 requested a review from acedrew May 6, 2024 19:21
@craig8 craig8 changed the base branch from main to releases/9.0.1 May 6, 2024 19:21
@craig8 craig8 requested a review from schandrika May 6, 2024 19:21
Handle behavior of removing PersistentDict
@acedrew
Copy link
Contributor

acedrew commented May 6, 2024

So this still requires the wide open on_any_event, or this works with on_closed?

@craig8
Copy link
Contributor Author

craig8 commented May 6, 2024

Works with on closed

@craig8
Copy link
Contributor Author

craig8 commented May 6, 2024

I will do an updated pr to 8.2 soon

@craig8 craig8 merged commit 61278c8 into VOLTTRON:releases/9.0.1 May 8, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web not loading users causing errors
3 participants