Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes when destination folder has been cleared #109

Open
ghost opened this issue Jan 30, 2023 · 3 comments
Open

closes when destination folder has been cleared #109

ghost opened this issue Jan 30, 2023 · 3 comments

Comments

@ghost
Copy link

ghost commented Jan 30, 2023

Step to reproduce on Debian:

  • run the updater so that the game can work
  • remove everything in the download folder, except the unvanquished folder
  • run the updater

What happens:

A popup saying Failed to start Unvanquished process. shows, and the updater ends.

What would be expected:

Updater should at least ask to repair (aka: reinstall).

@ghost ghost added the bug label Jan 30, 2023
@ghost
Copy link
Author

ghost commented Jan 30, 2023

Of course, clicking on the "settings" wheel allows to force the updater to download, but I think this should be done automatically. Clicking on that wheel is "not so simple" and normal users could think they need more extreme measures.

@slipher
Copy link
Contributor

slipher commented Jan 30, 2023

Checking the full installation integrity is not feasible, but I guess we could do a minimal check that the engine binary exists

@ghost
Copy link
Author

ghost commented Jan 30, 2023

It could be possible to check if the daemon executable fails to start, or returns too quickly. It could also be possible to make the updater place a marker that the client would remove if successfully started. If marker is still there when updater is run anew, then show an emergency window or something.
Just some random ideas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant