CG_CustomSound is broken

[cu-kai]

When testing the map mxl-school which appears to make use of these, the client is dropped by this line when falling off the ledge in the secret room by the computer room as a custom sound is triggered:

Unvanquished/src/cgame/cg_players.cpp

Line 92 in befc9f4

Sys::Drop( "Unknown custom sound: %s", soundName );

I have worked around this on Bunker by returning sounds/null.wav but that is a hack so I'm hesitant to PR such code until I understand why the existing code is broken.

[cu-kai]

Worth noting that the custom sound that causes the crash on mxl-school is one listed in this code: *falling1.wav

[sweet235]

What is a sensible method to handle the case of a missing sound file? I would say: do the same as with missing textures. Print a warning, play nothing.

[cu-kai]

I have this exact fix running on bunker but the sound that causes the crash is listed in cg_customSoundNames so I'd imagine we should solve the actual bug rather than work around it?

Unvanquished/src/cgame/cg_players.cpp

Lines 44 to 59 in befc9f4

	static const char *const cg_customSoundNames[ MAX_CUSTOM_SOUNDS ] =
	{
	"*death1",
	"*death2",
	"*death3",
	"*jump1",
	"*pain25_1",
	"*pain50_1",
	"*pain75_1",
	"*pain100_1",
	"*falling1",
	"*gasp",
	"*drown",
	"*fall1",
	"*taunt"
	};

[cu-kai]

In the Tremulous source code, the array of death sounds have extensions. Here, we do not have these.
See: https://github.com/darklegion/tremulous/blob/master/src/cgame/cg_players.c#L29-L44